Introduce ClassHash to uniquely identify classwrappers, make -fno-rtti work #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently micropython-wrap depends on typeid (RTTI) to do a full type check, and for naming anonymous classwrappers.
This PR replaces the use of RTTI by a static object based hash for types to perform the full type check. Also anonymously wrapped types can optionally function without RTTI, by naming them
AnonymousClasswrapper.As a side note: I've also experimented with naming the anonymous wrapper via
__PRETTY_FUNCTION__, but getting this to work reliably across all toolchains and versions is a bit of a mess. If you want, I can still implement this though.I've also tried adding a CI test run for
-fno-rtti, but I've not worked with appveyor yet, so lets see if this worked.